fix(FR-819): Fix share unit of resource preset.#3489
Merged
graphite-app[bot] merged 1 commit intoApr 14, 2025
Conversation
Contributor
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 4.18% | 409/9781 |
| 🔴 | Branches | 3.55% | 240/6765 |
| 🔴 | Functions | 2.54% | 79/3111 |
| 🔴 | Lines | 4.12% | 394/9566 |
Test suite run success
124 tests passing in 14 suites.
Report generated by 🧪jest coverage report action from 35ea13e
yomybaby
requested changes
Apr 14, 2025
Member
yomybaby
left a comment
yomybaby
left a comment
There was a problem hiding this comment.
- Ensure the server correctly handles whether CPU, memory, and accelerator values are numbers or strings. 1
- It's not ideal to arbitrarily fix values to 2. If the server expects strings, consider using the stringMode prop of InputNumber.
agatha197
force-pushed
the
fix_FR-819_/fix-share-unit-of-resource-preset
branch
from
cc5c1dd to
426e4d6
Compare
agatha197
force-pushed
the
fix_FR-819_/fix-share-unit-of-resource-preset
branch
from
426e4d6 to
35ea13e
Compare
Merge activity
|
Resolves #3485 ([FR-819](https://lablup.atlassian.net/browse/FR-819)) ## Add `stringMode` to InputNumber for Resource Preset Settings This PR adds the `stringMode` prop to the InputNumber component in the ResourcePresetSettingModal. This change ensures that decimal values are properly handled when users input resource allocation values, particularly for fields with fractional values. **Changes:** - Added `stringMode={true}` to the InputNumber component to preserve decimal precision in resource preset settings **Checklist:** - [ ] Documentation - [ ] Minium required manager version - [ ] Specific setting for review (eg., KB link, endpoint or how to setup) - [ ] Minimum requirements to check during review - [ ] Test case(s) to demonstrate the difference of before/after [FR-819]: https://lablup.atlassian.net/browse/FR-819?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
graphite-app
Bot
force-pushed
the
fix_FR-819_/fix-share-unit-of-resource-preset
branch
from
35ea13e to
44ee94f
Compare
graphite-app
Bot
deleted the
fix_FR-819_/fix-share-unit-of-resource-preset
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #3485 (FR-819)
Add
stringModeto InputNumber for Resource Preset SettingsThis PR adds the
stringModeprop to the InputNumber component in the ResourcePresetSettingModal. This change ensures that decimal values are properly handled when users input resource allocation values, particularly for fields with fractional values.Changes:
stringMode={true}to the InputNumber component to preserve decimal precision in resource preset settingsChecklist: